Skip to content

avoid "==" in assert! when one of the values is a bool #32761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2016
Merged

avoid "==" in assert! when one of the values is a bool #32761

merged 1 commit into from
Apr 6, 2016

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Apr 6, 2016

Is suspect this is something of an idiom

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 6, 2016

📌 Commit 922e666 has been approved by steveklabnik

@steveklabnik steveklabnik mentioned this pull request Apr 6, 2016
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 6, 2016
@steveklabnik
Rollup merge of rust-lang#32761 - tshepang:assert, r=steveklabnik
1e05e36 
avoid "==" in assert! when one of the values is a bool

Is suspect this is something of an idiom
@steveklabnik steveklabnik mentioned this pull request Apr 6, 2016
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 6, 2016
@steveklabnik
Rollup merge of rust-lang#32761 - tshepang:assert, r=steveklabnik
26aceab 
avoid "==" in assert! when one of the values is a bool

Is suspect this is something of an idiom
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 6, 2016
@steveklabnik
Rollup merge of rust-lang#32761 - tshepang:assert, r=steveklabnik
3531a1a 
avoid "==" in assert! when one of the values is a bool

Is suspect this is something of an idiom
@steveklabnik steveklabnik mentioned this pull request Apr 6, 2016
Merged
bors added a commit that referenced this pull request Apr 6, 2016
@bors
Auto merge of #32778 - steveklabnik:rollup, r=steveklabnik
bf5da36 
Rollup of 12 pull requests

- Successful merges: #31762, #32538, #32634, #32668, #32679, #32691, #32724, #32727, #32744, #32761, #32766, #32774
- Failed merges:
@bors bors merged commit 922e666 into rust-lang:master Apr 6, 2016
@tshepang tshepang deleted the assert branch April 7, 2016 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tshepang @rust-highfive @steveklabnik @bors @alexcrichton